Thanks David for your prompt response. I presume after refactoring the code for
readability then the next step would be to introduce the State Design pattern
for conditionals such as the one I have ?
Regards,
Aswin.
David Pokluda <[EMAIL PROTECTED]> wrote: P { MARGIN-TOP: 0px;
MARGIN-BOTTOM: 0px } This code is totally unreadable. Whenever I have a
complex condition that is hard to use I try at least ExtractMethod refactoring
(http://www.refactoring.com/catalog/extractMethod.html) so that I can at least
read the code. You can further improve readability with ReverseConditional
refactoring (http://www.refactoring.com/catalog/reverseConditional.html). You
can also take a look at
http://www.refactoring.com/catalog/consolidateConditionalExpression.html.
David.
---------------------------------
From: [EMAIL PROTECTED] [EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED]
[EMAIL PROTECTED]
Sent: Wednesday, November 14, 2007 6:36 PM
To: [email protected]
Subject: [patterns-discussion] Design pattern recommendation
Hello to all the four who replied (I guess a Gang of Four did reply to my
message!!)
Thanks for all the suggestions. I will certainly look at all of them closely.
Though it looks I may need the State pattern. I will also buy that book that
was recommended.
In any case here is the code thats hard to read
Basically thats the code that I am trying to refactor ( I have relabeled the
methods )
if (call.isNothingReturned() && (cCall.hasLockingCondition() ||
getUtility().usesConfig() )
&& (!call.shouldBuildObject()) &&
(getUtility().externalWriteUtility() || (!call.hasParameters())) &&
(!call.isWriteRequired()))
---------------------------------
Get easy, one-click access to your favorites. Make Yahoo! your homepage.
---------------------------------
Never miss a thing. Make Yahoo your homepage._______________________________________________
patterns-discussion mailing list
[email protected]
http://lists.cs.uiuc.edu/mailman/listinfo/patterns-discussion
