Hi Martin, Thanks for your review. See inline...
> ---------------------------------------------------------------------- > COMMENT: > ---------------------------------------------------------------------- > > Hi, > > thanks for this document, here are a couple of comments/questions. > > The PCEP ASSOC-Type-List TLV is optional. It MAY be carried within > an OPEN object sent by a PCEP speaker in an Open message to a PCEP > peer so as to indicate the list of supported Association types. > This is said twice. (First paragraph of section 4.1) and then in 4.1.1: > A PCEP speaker MAY include an ASSOC-Type-List TLV within an OPEN > object in an Open message sent to a PCEP peer in order to advertise a > set of one or more supported association types. > The use of ASSOC-Type-List TLV is OPTIONAL. > > It doesn't hurt, but you might want to consider saying this only once. > Also I note OPTIONAL vs optional > [[Dhruv Dhody]] Ack. > Sending ASSOC-Type-List TLV is optional but it might be mandatory to send > some to-be-defined Association types. Isn't that somehow conflicting? > [[Dhruv Dhody]] The aim was to say that right now this TLV is optional, but a future association type (say disjoint) can specify that if you want to use *this particular association type* you need to include the TLV. So if an implementation does not support this particular association type, the TLV would be optional, and if it needs to support this, then the TLV becomes mandatory to include. > The PCEP OP-CONF-ASSOC-RANGE TLV is optional. > OPTIONAL? > [[Dhruv Dhody]] Ack. > Could you clarify the difference between a PCEP speaker does not recognize > the ASSOCIATION object and a PCE peer is ... unable to process the > ASSOCIATION I see that the errors thrown are different. > [[Dhruv Dhody]] The difference is between ASSOCIATION Object being unknown (former) and Object being known *but* not supported/processed (latter). > Nits: > s/protections LSPs/protection LSPs/ > s/The Assoc-type MAY appear more than once/A given Assoc-type MAY appear > more than once/ s/to uniquely identifying/to uniquely identify/ > > [[Dhruv Dhody]] Ack. Working Copy: https://raw.githubusercontent.com/dhruvdhody-huawei/ietf/master/draft-ietf-pce-association-group-10.txt Diff: https://tools.ietf.org/rfcdiff?url1=draft-ietf-pce-association-group-09&url2=https://raw.githubusercontent.com/dhruvdhody-huawei/ietf/master/draft-ietf-pce-association-group-10.txt Thanks! Dhruv > _______________________________________________ > Pce mailing list > [email protected] > https://www.ietf.org/mailman/listinfo/pce _______________________________________________ Pce mailing list [email protected] https://www.ietf.org/mailman/listinfo/pce
