Hi Ben, Authors, > > I note in a few places in the section-by-section comments that the figures > > seem to indicate a 'D' flag in PCInitiate and PCUpd messages, and the only > > D flag I see mentioned in the prose is the Delegate flag in a PCRpt. This > > seems particularly important to check and get right (though I admit that I > > could just be missing something). > > > > Shuping> Yes, D flag is the Delegate flag. Changed the text so that it is > > applicable for other PCEP messages as well - "The ingress PCC and PCE MUST > > also set D (Delegate) flag (see [RFC8231]) and C (Create) flag (see > > [RFC8281]) in the LSP object in the initial exchange." > > It's good to have the prose and figure consistent, but I'm still a little > confused as to whether it's needed to set the D flag for PCInitiate and > PCUpd -- RFC 8281 does not appear to say anything at all about the flag in > those messages (whether to set it or clear it), so I guess the only > guidance we have is what implementations of 8281 do in practice. If they > do set the D flag, then continuing to do so (and documenting that) makes > sense, but otherwise it's not clear to me that there is a reason to change > things in this document. >
My suggestion to the authors would be to remove D=1 from the figures for the PCInitiate message and match that to the prose as well. The behavior here is not new and it should simply refer to RFC8281. D=1 for PCUpd is fine and should stay as per RFC8231. Thanks! Dhruv _______________________________________________ Pce mailing list [email protected] https://www.ietf.org/mailman/listinfo/pce
