Hi WG, I have finished the Shepherd review of draft-ietf-pce-lsp-extended-flags-02. Please find my comments. Once these are resolved we will be sending the I-D to IESG for publication.
* Date: 7 June 2022 * Reviewer: Dhruv Dhody ## Minor * Abstract should not have references. Replace all [RFCNNNN] with RFC NNNN. Also for the I-D add a note to RFC Editor "Replace I-D.ietf-pce-binding-label-sid to RFC XXXX, once the RFC number is assigned." * Add a Management Considerations Section ```` Management Considerations Implementations receiving set LSP Extended Flags that they do not recognize MAY log this. That could be helpful for diagnosing backward compatibility issues with future features that utilize those flags. ```` * Small update to Security Consideration Section ```` OLD: For LSP Object procssing security considerations, see [RFC8231]. No additional security issues are raised in this document beyond those that exist in the referenced documents. NEW: [RFC8231] sets out security considerations for PCEP when used for communication with a stateful PCE. This document does not change those considerations. For LSP Object processing, see [RFC8231]. This document provides for future extension of PCEP. No additional security issues are raised in this document beyond those that exist in the referenced documents. ```` * Please add this to the appendix to capture the WG LC discussion ```` Appendix A. WG Discussion The WG discussed the idea of a fixed length (with 32 bits) for LSP- EXTENDED-FLAG TLV. Though 32 bits would be sufficient for quite a while, the use of variable length with a multiple of 32-bits allows for future extensibility where we would never run out of flags and there would not be a need to define yet another TLV in the future. Further, note that [RFC5088] and [RFC5089] use the same approach for the PCE-CAP-FLAGS Sub-TLV and are found to be useful. ```` ## Nits * Title: s/LSP/Label Switched Path (LSP)/ * s/syncronization/synchronization/ * s/procssing/processing/ Thanks! Dhruv
_______________________________________________ Pce mailing list [email protected] https://www.ietf.org/mailman/listinfo/pce
