Éric Vyncke has entered the following ballot position for draft-ietf-pce-lsp-extended-flags-07: No Objection
When responding, please keep the subject line intact and reply to all email addresses included in the To and CC lines. (Feel free to cut this introductory paragraph, however.) Please refer to https://www.ietf.org/about/groups/iesg/statements/handling-ballot-positions/ for more information about how to handle DISCUSS and COMMENT positions. The document, along with other ballot positions, can be found here: https://datatracker.ietf.org/doc/draft-ietf-pce-lsp-extended-flags/ ---------------------------------------------------------------------- COMMENT: ---------------------------------------------------------------------- # Éric Vyncke, INT AD, comments for draft-ietf-pce-lsp-extended-flags-07 CC @evyncke Thank you for the work put into this document. Please find below some non-blocking COMMENT points (but replies would be appreciated even if only for my own education). Special thanks to Dhruv Dhody for the shepherd's detailed write-up including the WG consensus and the justification of the intended status. I hope that this review helps to improve the document, Regards, -éric ## COMMENTS ### Section 1 While I am not sure whether the description of the current use of the 12 bits is useful: suggest to replace `Thus, it is required to extend the flag field of the LSP Object for future use.` but ``This document extends the flag field of the LSP Object for other use.` (it should age better) ### Section 3.1 `Length (16 bits): multiple of 4 octets.` is rather confusing... Is this field counting 32-bit words ? I had to read RFC 5440 to understand that the 'value' part is always a multiple of 4 octets. Strongly suggest to say "Length (16 bits): length of the value expressed in octets". ## Notes This review is in the ["IETF Comments" Markdown format][ICMF], You can use the [`ietf-comments` tool][ICT] to automatically convert this review into individual GitHub issues. [ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md [ICT]: https://github.com/mnot/ietf-comments _______________________________________________ Pce mailing list [email protected] https://www.ietf.org/mailman/listinfo/pce
