Hello!
PCMan has written on Wednesday, 23 May, at 23:47:
[.......]
>I'm going to apply your patch later after a review.
Thank you very much! Also for unneeded reference which I missed on
call to fm_file_info_set_path() that you fixed. And there is one more
file where you haven't fixed that, it's src/gtk/fm-places-model.c, there
are 3 calls fm_path_ref which should be removed too.
Also I found one own bug in the patch. I've updated the patch in
tracker but it seems you've got it before my fix. It's about call for
fm_file_info_get_mtime() which returns not value but pointer. Line at
src/gtk/fm-folder-model.c:713, it should be changed:
- ret = fm_file_info_get_mtime(file1) - fm_file_info_get_mtime(file2);
+ ret = *(fm_file_info_get_mtime(file1)) -
*(fm_file_info_get_mtime(file2));
With best wishes.
Andriy.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Pcmanfm-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pcmanfm-develop
