Hello, PCMan!
While you're working on the fm_search_* and I've looked into it I
found it too much overcomplicated. I would like to gather it into one
place, exactly src/job/fm-file-search-job sources and simplify it to
something not much complicated than, let say, fm-file-info-job, but
probably with addition of some search attributes such as recursive. But
main APIs should be as simple as possible:
FmFileSearchJob * fm_file_search_job_new(void);
gboolean fm_file_search_job_add_uri(FmFileSearchJob *job, const char *uri);
since we agreed already that main request will be via URI (as some kind
of URI will be needed for path widget anyway so why overcomplicate it?).
There may be some convenience APIs such as fm_file_search_set_recursive
and similar but I doubt those will be ever used.
And of course, main GUI engine will be some class that opens a search
dialog and then watches for finished search so it can start new search or
cancel current. And of course, search will be cancelled if user changes
directory as well.
So how about merging fm-file-search into fm-file-search-job? It will
make it simpler and faster as it eliminates interface-to-interface calls.
And I'm waiting your responce to my fm-file.c proposal, we can add
that simple prototype into 1.0.2 and use it later adding scheme handlers.
I believe only search job and fm-file prototype should go into 1.0.2, all
the rest will come later in 1.1.
Cheers!
Andriy.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Pcmanfm-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pcmanfm-develop
