On 6 October 2014 20:17, Andrej N. Gritsenko <[email protected]> wrote: > Hello!
Hai there! > Thank you very much for noticing this. Though it requires a bit more > than that in your patch otherwise you'll meet a crash as sel pointer is a > pointer provided by caller. And also there may be not provided any app as > default (in most of cases there is none). Thank you anyway, I'll do some > changes at that API later to correct the behavior. Apologies if I'm missing something, and you certainly have much greater knowledge of the code in question, but if mime_type is not NULL then the caller provided apps and sel pointers are irrelevant and we proceed to set the pointers ourselves. The patch doesn't change this and I don't see how it could introduce a crash. Secondly, g_app_info_get_default_for_type() can either return a GAppInfo object or NULL; both cases are handled correctly as far as I can see. If no default application is set, it will still return an application that can handle the specified mime type (unless there are none, of course). Again, I'm sorry for my possibly incorrect follow up post and thank you for looking into this. :) ------------------------------------------------------------------------------ Slashdot TV. Videos for Nerds. Stuff that Matters. http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk _______________________________________________ Pcmanfm-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/pcmanfm-develop
