On Sat, 27 Feb 2010, Bo Rydberg wrote: > Attached are the modified files. Part of the changes is based on, hmm, > my allergy against the unnecessary use of reinterpret_cast when > static_cast will do. Thus, the casts have no bearing on the Symbian OS > perspective.
I have had a quick look at your files, and forwarded them on to the folks who maintain the C++ wrapper. One comment: The file config.h is automatically generated by automake, so it's not possible to make the kind of changes you suggest without revising the automake process and using non-standard macros - which I'm not skilled at doing. The files pcre_stringpiece.h, and pcrecpparg.h are also automatically generated from their .h.in originals, where the comments you suggest are obvious. For example, you have the line #if 1 // @pcre_have_long_long@ in pcrecpparg.h, but in the original .in file it reads #if @pcre_have_long_long@ so anybody working on that can see what it really is. Though I guess a comment might be helpful for people coming new to the code. Philip -- Philip Hazel -- ## List details at http://lists.exim.org/mailman/listinfo/pcre-dev
