Hi, > This was a patch to Git as you might have guessed: > https://public-inbox.org/git/20171122133630.18931-2-ava...@gmail.com/T/#u > Do you think I need to go back and rework that so I do #1 as well? A > pedantic reading of the manpage would probably suggest so, but I can't > see how the JIT compiled size would ever be zero without JIT being > disabled...
No, you don't. The #1 is useful if you compile the pattern in multiple modes (e.g. partial matching modes). Your patch seems correct. Yes, a compiled pattern cannot have code size 0. That is impossible. I also landed a fix to return with bad option if no compiled code is available. Regards, Zoltan -- ## List details at https://lists.exim.org/mailman/listinfo/pcre-dev
