On Mon, Nov 11, 2019 at 7:23 AM Petr Pisar via Pcre-dev <pcre-dev@exim.org> wrote: > Maybe the label definition should be guarded with #if defined(FF_UTF). >
Yes, you are right. I will send an updated patch. > > And this warning is more worrysome: > > In file included from src/pcre2_jit_compile.c:5522: > src/pcre2_jit_simd_inc.h: In function 'shift_left_n_lanes': > src/pcre2_jit_simd_inc.h:871:1: warning: control reaches end of non-void > function [-Wreturn-type] > 871 | } > | ^ > > Shouldn't the vect_t shift_left_n_lanes(vect_t a, sljit_u8 n) function return > a? I will add an assert that there are no more other cases to handle in the switch and then add a `default: return a;`. Thanks Petr for testing. Sebastian -- ## List details at https://lists.exim.org/mailman/listinfo/pcre-dev
