Duh... I had grabbed the Pd-0.42.5-extended tarball... it does indeed look like the fixes are alreay in. Sorry for the trouble.
Miller On Mon, Sep 03, 2012 at 06:05:18PM -0400, Hans-Christoph Steiner wrote: > > Which version are you using? These fixes are already be included in > cyclone in SVN: > > http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&sortby=date&revision=15018 > http://pure-data.svn.sourceforge.net/viewvc/pure-data?view=revision&sortby=date&revision=15651 > > .hc > > On 09/03/2012 04:49 PM, Miller Puckette wrote: > > To Pd developers... > > > > In testing the coll object from cyclone/hammer I found some trouble adapting > > from 0.42 to 0.43. I had no trouble fixing it locally (I'll show a diff > > below) but would like now to know how I can best make this available to > > others. Would it be netter that I (a) submit a patch to the tracker (that > > would work if Hans would then want to apply it to SVN) or should I risk > > trying to commit to SVN myself (with the risk that I migth do something > > stupid and mess up the repo)? > > > > here's the change, although to patch it upstream I'd want to make the code > > check the Pd version in runtime so that it will still work for Pd <= 0.42 ) > > > > diff externals/miXed/shared/hammer/file.c ~/work/text/coll/ > > > > > > < sys_gui(" pd [concat miXed$name clear \\;]\n"); > > --- > >> sys_gui(" pdsend [concat miXed$name clear \\;]\n"); > > 123c123 > > < sys_gui(" pd [concat miXed$name addline $lin \\;]\n"); > > --- > >> sys_gui(" pdsend [concat miXed$name addline $lin \\;]\n"); > > 126c126 > > < sys_gui(" pd [concat miXed$name end \\;]\n"); > > --- > >> sys_gui(" pdsend [concat miXed$name end \\;]\n"); > > 271,272c271,272 > > < sys_gui(" pd [concat $target path \\\n"); > > < sys_gui(" [pdtk_enquote $filename] [pdtk_enquote $directory] > > \\;]\n"); > > --- > >> sys_gui(" pdsend [concat $target path \\\n"); > >> sys_gui(" [enquote_path $filename] [enquote_path $directory] > >> \\;]\n"); > > 287,288c287,288 > > < sys_gui(" pd [concat $target path \\\n"); > > < sys_gui(" [pdtk_enquote $filename] [pdtk_enquote $directory] > > \\;]\n"); > > --- > >> sys_gui(" pdsend [concat $target path \\\n"); > >> sys_gui(" [enquote_path $filename] [enquote_path $directory] > >> \\;]\n"); > > thanks > > Miller > > > > > > _______________________________________________ > > Pd-dev mailing list > > Pd-dev@iem.at > > http://lists.puredata.info/listinfo/pd-dev > > > _______________________________________________ > Pd-dev mailing list > Pd-dev@iem.at > http://lists.puredata.info/listinfo/pd-dev _______________________________________________ Pd-dev mailing list Pd-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
