Patches item #3528891, was opened at 2012-05-22 10:42 Message generated for change (Settings changed) made by zmoelnig You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3528891&group_id=55736
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: puredata Group: bugfix >Status: Closed Resolution: Accepted Priority: 3 Private: No Submitted By: Glen F (totalgee) Assigned to: Nobody/Anonymous (nobody) Summary: Fixing a few compiler warnings on OS X (LLVM) Initial Comment: A few very minor changes. A couple of these fix pointer dereferencing which was subsequently not used (has no effect other than causing a warning with the LLVM compiler on OS X). The only important part is the advancing (++) of the pointers, which remains as it was. In the other case, an error() function with variable arguments was being printed using an uncontrolled format string (http://en.wikipedia.org/wiki/Uncontrolled_format_string). In the context of the actual code, I don't think it actually is a safety issue -- but it does get rid of another compiler warning/error with the latest LLVM compiler. This is my first (admittedly very minor) patch submission, I hope it's okay. I had submitted a pull request on the libpd GitHub project, but they informed me it was better to apply it to the original Pd "vanilla" source, which they just bring over verbatim from time to time. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=478072&aid=3528891&group_id=55736 _______________________________________________ Pd-dev mailing list Pd-dev@iem.at http://lists.puredata.info/listinfo/pd-dev
