... but isn't it simpler just to set -Wno-logical-op-parentheses etc. when compiling?
I noticed that you also propose adding #include <stdlib.h> to m_pd.h - I don't know why that would be necessary (and I think I should take stdio out of it if that can be done without breaking too much code. cheers M On Thu, Mar 24, 2016 at 09:27:18PM -0600, Dan Wilcox wrote: > The last patch fixed some of the warnings. The rest I’m seeing from clang are > simple stuff: > > warning: using the result of an assignment as a condition without > parentheses [-Wparentheses] > aka > assignments in for loops & if/while statements should be wrapped in > parens > > warning: '&&' within '||' [-Wlogical-op-parentheses], so added paren > wraps > > switch statement not handling all enumerations, so added default: break; > > Note: this is only for sources used by libpd. > > Here’s a patch: > > > > >> On Mar 22, 2016, at 10:39 AM, Miller Puckette <[email protected] > >> <mailto:[email protected]>> wrote: > >> > >> It's already in and up - check away :) > >> > >> M > >> On Tue, Mar 22, 2016 at 10:37:20AM -0600, Dan Wilcox wrote: > >>> Sweet. clang on OSX gives me about 100+ warnings when building the > >>> pure-data sources for libpd, most of which involve simple things like > >>> suggested paren wraps, “implicit conversion loses integer precision,” > >>> etc. These might be related to what iOhannes is seeing. I’ll wait to see > >>> if this bugfix work is accepted and then I can make a similar patch for > >>> the warnings. > >>> > >>> -------- > >>> Dan Wilcox > >>> @danomatika <https://twitter.com/danomatika > >>> <https://twitter.com/danomatika>> > >>> danomatika.com <http://danomatika.com/> <http://danomatika.com/ > >>> <http://danomatika.com/>> > >>> robotcowboy.com <http://robotcowboy.com/> <http://robotcowboy.com/ > >>> <http://robotcowboy.com/>> > >>>> On Mar 22, 2016, at 5:00 AM, [email protected] > >>>> <mailto:[email protected]> wrote: > >>>> > >>>> From: IOhannes m zmölnig <[email protected] <mailto:[email protected]> > >>>> <mailto:[email protected] <mailto:[email protected]>>> > >>>> Subject: Re: [PD-dev] Memory leaks? > >>>> Date: March 21, 2016 at 3:29:25 PM MDT > >>>> To: [email protected] <mailto:[email protected]> > >>>> <mailto:[email protected] <mailto:[email protected]>> > >>>> > >>>> > >>>> On 03/21/2016 09:51 PM, Miller Puckette wrote: > >>>>> Yep, thanks. Fixing it now... > >>>> > >>>> since you seem to be in bug-squashing mode: there are about 100 more > >>>> bugs waiting to be fixed :-) > > -------- > Dan Wilcox > @danomatika <https://twitter.com/danomatika> > danomatika.com <http://danomatika.com/> > robotcowboy.com <http://robotcowboy.com/> > _______________________________________________ Pd-dev mailing list [email protected] http://lists.puredata.info/listinfo/pd-dev
