On 2018-09-11 12:49, Dan Wilcox wrote: > 7. Testing before merging: This is possible by adding the PR author's repo as > a remote and then pulling whatever branch (master or otherwise) they > submitted the PR with. This allows you to essentially do a checkout of their > PR branch that you can build locally.
personally, i always do a local investigation of PRs before merging them (unless the changes are trivial). so i practically never use github's "merge" button. however, i've found that adding the PR author's repos as remotes quickly gets painful, the more PRs there are, as it adds all the branches of the PR author's repo to mine. and i tended to forget to remove them. so i was *very* thankful when chr13m pointed me to a solution to only pull a specific PR in [1]. later i learned that there's a "git pr" command (on Debian this is shipped in the "git-extras" package; i don't know about Fedora), which does essentially the same: e.g. to locally fetch PR#440, i just cd into my pure-data.git dir and run: ~~~ $ git pr 440 ~~~ fgasdmr IOhannes [1] https://lists.puredata.info/pipermail/pd-dev/2018-06/021591.html
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Pd-dev mailing list Pd-dev@lists.iem.at https://lists.puredata.info/listinfo/pd-dev
