I originally didn't put "include guards" in any Pd source files as they were never necessary (and I always thought that, when possible, it's better to do all your including yourself instead of letting files defensively include stuff). But this is clearly not workable once things get to a certain level of lib-calling-lib-calling-lib complexity, so I guess it's time to stick them in. The others all got fixed by one PR or another. I'll go on and fix this one.
cheers M On Tue, Aug 11, 2020 at 11:53:01AM +0200, Christof Ressi wrote: > I am pretty sure this is an oversight. The header contains struct > declarations, so it must be guarded and #defines, so it must be guarded. > > On 11.08.2020 11:39, Dan Wilcox wrote: > > Howdy all, > > > > I noticed today that g_all_guis.h does not have #if/#def include guards. > > Is this an oversight or is there some reason? > > > > -------- > > Dan Wilcox > > @danomatika > > <https://urldefense.com/v3/__http://twitter.com/danomatika__;!!Mih3wA!QEH0DvcmOi6V-n__ZsN2z-Kf_xCgRp7iY89n0z_Hs_LQriYTjaqJE61jnBGp$ > > > > > danomatika.com > > <https://urldefense.com/v3/__http://danomatika.com__;!!Mih3wA!QEH0DvcmOi6V-n__ZsN2z-Kf_xCgRp7iY89n0z_Hs_LQriYTjaqJE7ZXLVP6$ > > > > > robotcowboy.com > > <https://urldefense.com/v3/__http://robotcowboy.com__;!!Mih3wA!QEH0DvcmOi6V-n__ZsN2z-Kf_xCgRp7iY89n0z_Hs_LQriYTjaqJE8grFj-s$ > > > > > > > > > > > > > _______________________________________________ > > Pd-dev mailing list > > [email protected] > > https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!Mih3wA!QEH0DvcmOi6V-n__ZsN2z-Kf_xCgRp7iY89n0z_Hs_LQriYTjaqJE257lxn4$ > _______________________________________________ > Pd-dev mailing list > [email protected] > https://urldefense.com/v3/__https://lists.puredata.info/listinfo/pd-dev__;!!Mih3wA!QEH0DvcmOi6V-n__ZsN2z-Kf_xCgRp7iY89n0z_Hs_LQriYTjaqJE257lxn4$ > _______________________________________________ Pd-dev mailing list [email protected] https://lists.puredata.info/listinfo/pd-dev
