On 5/8/24 22:50, Dan Wilcox wrote:
PD_VERSION_CODE was added and shows up in the grep output as a second line. The fix is to simply filter it out when grabbing the values. A fix is here:https://github.com/pure-data/pure-data/pull/2298
i missed your PR and submitted my own version for the fix, with a slightly different approach: - use autotools $(VERSION) rather than doing the brittle calculations ourselves (this shifts the authoritative source for the version from m_pd.h to configure.ac; i think this is no great loss, as they must be in sync anyhow)
- also implement a fix for the non-autotools buildsystems (src/makefile.*)- here i tightened the search filter to only include #defines of (e.g.) 'PD_MAJOR_VERSION' itself, and not some arbitrary line that contains the "PD_MAJOR_VERSION" string (and filtering out known false-positives, like lines containing also "PD_VERSION_CODE")
<https://github.com/pure-data/pure-data/pull/2299> gfmdsr IOhannes
OpenPGP_signature.asc
Description: OpenPGP digital signature
_______________________________________________ Pd-dev mailing list [email protected] https://lists.puredata.info/listinfo/pd-dev
