Le dimanche 05 septembre 2010 à 13:27 -0400, Mathieu Bouchard a écrit : > On Wed, 1 Sep 2010, Ed Kelly wrote: > > > But, I have noticed a sinusoidal error with the graphics in my patch. > > So, here is the real thing! > > 1. [abs] just before [pow 2] is completely useless. Wrong, that depend : float -2 -> pow 2 doesn't give 4 but 0. So [abs] can be useful to get 4. I can' open the .rar archive of Ed, therefore i can't test to see if you get negative value. ++
Jack > > 2. using pow(opposite/hypotenuse,2) as an angle to [tan] doesn't make any > sense whatsoever. > > 3. what you need there is just opposite/adjacent, no square, no tan. > the opposite/adjacent is already the tangent of an angle, and you don't > need make that angle explicit at all. > > 4. even if you just compute that ratio with [/] and [swap], there is still > a sign error in half of the cases (do you know how to fix this ?). > > 5. why do you need to shear two rectangles, instead of shearing a single, > longer one ? > > _______________________________________________________________________ > | Mathieu Bouchard ------------------------------ Villeray, Montréal, QC > _______________________________________________ [email protected] mailing list > UNSUBSCRIBE and account-management -> > http://lists.puredata.info/listinfo/pd-list _______________________________________________ [email protected] mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list
