Hi Shahrokh et all - I think the simplest way (for submitters and for me) is for you to clone the git repo:
git clone git://git.code.sf.net/p/pure-data/pure-data then edit files as desired, git commit git log (this gives something like: commit 90608feff2e7b24c1b0d37e38ba196500b6641ab Author: Miller Puckette <[email protected]> Date: Tue May 26 13:26:06 2015 -0700 fix bug allowing /dev/midi and /dev/midi1 to falsely match commit 6daab96dacead99f37e2245ce797377fcf6410a7 Author: Miller Puckette <[email protected]> Date: Sun May 24 19:10:49 2015 -0700 ) and then... git format-patch [-o /tmp] ^6daab96da 90608feff then add a patch to the SF patch tracker: http://sourceforge.net/p/pure-data/patches/ attaching the git-generated patch file. Then pop me a personal e-mail to remind me to look at the patch tracker - some weeks I'm good about that and some other weeks I forget. :). (I do this now to try to maintain coherence between the "released" (0.46) and "bleeding edge" (0.47) branches. The one bother I've noticed is that, if I commit something, discover a bug, and make another commit to fix that, it appears as two files in the git diff - I can't find any way to erase the intervening commit. I'm learning that 'git commit --amend' sometimes helps me avoid this problem.) cheers Miller On Sun, Jun 07, 2015 at 11:08:14PM -0700, Shahrokh Yadegari wrote: > Hi Alexandre, > > This seems to be a bug. I am not sure why I missed the 'n' on the name > either. As it seems that this function has never worked, we should fix the > name as well. The solution is simple as follows: > > extra/expr~/vexp_fun.c > > 188c188 > > < {"copysign", ex_copysign, 2}, > > --- > > > {"copysig", ex_copysign, 1}, > > > I checked the mailing list (I am sorry that I am not a regular reader) and > I see some concerns about the maintenance of the code. I am happy to fix > the problems and I thought I sent you a fix for the last problem you had > found in 2009. Can somebody point me to a document or a webpage that > explains what the best way is to introduce new changes to the pd source > base. Miller, should I pass the fixes to you, or is there another > repository? > > In the meanwhile, if there are other bugs in expr that anybody else knows, > please send them to me and I will fix them as soon as I can. > > best, > Shahrokh > > On Sun, Jun 7, 2015 at 12:57 PM, Alexandre Torres Porres <[email protected]> > wrote: > > > hi there, I was checking the source of expr (find it attached) and saw > > this "copysign" function that I needed for a formula, but I can't get it to > > work/load. > > > > I'm trying something like [expr copysign($f1)] and it's not happening. The > > expr manual page in http://yadegari.org/expr/expr.html tells about this > > function as well, here it is: > > > > copysign() > > 1 > > copy sign of a number(added in version 0.4) > > > > So it seems I'm supposedly doing the right thing... is it a bug? I'm on > > extended 0.42 and it says that it's expr version 0.4 when it loads. > > > > cheers > > > > > > -- > Shahrokh Yadegari > Professor of Composition and Sound Design, > Theatre and Dance Department > University of California, San Diego > Director, Initiative for Digital Exploration of Arts and Science, (IDEAS) > California Institute for Telecommunications and Information Technologies > (Calit2) > Email: [email protected] > Web: http://yadegari.org > Tel: (858) 822-4113 > Fax: (858) 534-1080 > _______________________________________________ > [email protected] mailing list > UNSUBSCRIBE and account-management -> > http://lists.puredata.info/listinfo/pd-list _______________________________________________ [email protected] mailing list UNSUBSCRIBE and account-management -> http://lists.puredata.info/listinfo/pd-list
