Hi, thanks for 0-56-0tedt3 :) I know we're in a freezing phase focusing on show-stopping bugs fixes, but I'd like to take a moment and also think about the big and very exciting change regarding the inclusion of colors.
I was quiet about it, but I was thinking that the order of color makes more sense if we start with 'background', then Charles just opened an issue saying how starting with foreground is also inconsistent to iemguis ==> https://github.com/pure-data/pure-data/issues/2696 So hopefully we can have a final momento to see if there are minor details that are best being reviewed right now before it's sealed. I wasn't checking and comparing to the iemguis colors and I now more strongly agree that the order should start with "background". Ben also said it's a good time to question this and how it also makes sense. Another thing is that we can say that colors are still "experimental" and might change. I marked them as "experimental" on the release notes and docs here right now --> https://github.com/pure-data/pure-data/pull/2695 but I wasn't emphatic on the aspect that "things might change". Should I be more explicit? I was more telling that this is still incomplete, not mentioning really what, but, for instance, the Pd console window and the text window of [text] should also follow suit... And while we're at it, I have to say I don't see the point of also setting the GOP color (4th argument) to the selection color if we only have 3 args... it kinda points to the fact that the GOP color is not important and could be ignored or something. I can see the point of taking it as an optional argument and simply not set it if we have 3 args. I can envision this 4th color - which defaults to red (and is only marked as the visible GOP rectangle on patches) - as being used for other elements. In fact, the iemgui's default color for displaying numbers while the number box is active was red by default, and now uses this GOP color! I actually never liked how iemgui's number box marked the object as active anyway and I think this could change by simply filling the left triangle to the foreground color. Using 'GOP' color makes sense now, keeps things the same and allows for some control though. I just wanna say I don't think it "has" to use Pd's GOP color, but it's an example that this color could be used elsewhere. Since this color is 'red' by default, it could also be used as the "error" color for the Pd console window, for instance. So it could be named as something else, like "highlight" color, to be used as errors, GOP rectangle, [nbx]'s activity and maybe other stuff I'm missing right now. But my point is, not ignore this color and embrace it... don't promote its oblivion by applying it as the selection color. Hence, I'd like to discuss this with the community for more thoughts. For now, I would suggest: 1) Start with background color; 2) Have "GOP" color untouched as an optional argument (only change it if the 4th argument is given). I could also highlight in the documentation more explicitly on how really really experimental this is and how it might probably change... Cheers
--- pd-list@lists.iem.at - the Pure Data mailinglist https://lists.iem.at/hyperkitty/list/pd-list@lists.iem.at/message/LE255CFHGEQ4IKAET7PNZP4WGJ6TCZLM/ To unsubscribe send an email to pd-list-le...@lists.iem.at mailing list UNSUBSCRIBE and account-management -> https://lists.iem.at/
