Well, Here are the modified patches before committed.
/* Copyright (C) 2007, 2008 Free Software Foundation, Inc. */ Since you wrote it in 2008 then the copyright notification should not mention 2007. It should be (C) 2008 Free Software Foundation... /* Time-stamp: <2008-02-23 19:07:30 gerel> */ Please follow the conventions explained in http://gnupdf.org/Dev:Coding_Conventions#File_Header for the file header. The time-stamp should be put in the first line of the file along with the emacs mode indicator. /* TODO: add missing status codes */ Please remove this TODO entry. People usually use TODO, FIXME, etc to search for incomplete functionality that should be fixed. This is not the case: it is obvious that we will be incorporating new status codes as we define it. #endif /* PDF_ERROR_H */ --- EOF pdf-error.h --- Please add a line with: /* End of FILE-NAME */ +2008-02-24 gerel <[EMAIL PROTECTED]> + + * src/base/pdf-error.[ch] (Error management): added first implementation. + 2008-02-24 Jose E. Marchesi <[EMAIL PROTECTED]> * doc/gnupdf-tsd.texi: New file. To include the ChangeLog entry as part of a diff patch is usually a bad idea: you will surely get a conflict when applying your patch! It is much better to send the ChangeLog entry separated. PUBLIC_HDRS= ... base/pdf-stm-f-pred.h \ base/pdf-stm-f-rl.h \ base/pdf-stm-file.h \ - base/pdf-stm.h + base/pdf-stm.h \ + base/pdf-error.h You forgot to enclose the exported parts of `pdf-error.h' with /* BEGIN PUBLIC */ and /* END PUBLIC */. Please do it to allow `extract-public-hdr' to get the public definitions from the header file and put it in pdf.h. torture/test-obj_createdestroy.c torture/test-obj_dict.c torture/test-obj_dupequality.c torture/test-rectangle.c torture/test-stm_openclose.c + +Gerdardo E. Gidoni: src/base/pdf-error.c, src/base/pdf-error.h --- EOF AUTHORS --- Please follow the convention actually used in AUTHORS: Mr. Foo: wrote foo.h foo.c and changed baz.h In your case it would read: Gerardo E. Gidone: wrote src/base/pdf-error.c src/base/pdf-error.h BTW, I'm not sure about src/Makefile.am, I hope it's ok. It is ok :) Please fix these things and commit the code. Thanks.
