Hi hi, > here are some unit tests for hash helpers (pdf-hash-add-bool, > pdf-hash-add-i32 and pdf-hash-addu32). >
Some minor things: +/* Copyright (C) 2008-2011 Free Software Foundation, Inc. */ New files should have listed only the current year in the copyright line. +#include <check.h> +#include <pdf-test-common.h> +/* + * Test: pdf_hash_add_bool_001 Please add an empty line between the last include and the beginning of the test description. And regarding the tests themselves: * For booleans, include tests adding TRUE and FALSE. * For u32s, include tests not only for the MAX u32, but also for the minimum one (0), just for completeness. * For i32s, include tests not only for the MAX i32, but also for the MIN i32. Cheers! -- Aleksander
signature.asc
Description: This is a digitally signed message part
