On Nov 17, 2008, at 9:14 PM, Jukka Zitting wrote:
Hi,
Andreas and Brian, thanks for the effort!
I tried to review your work but unfortunately I'm not a PDF expert and
didn't have too much time to focus on this so I couldn't tell what's
the current status with your changes. However, unless some of our
normal committers chimes in, I trust your work and would like to use
my mentor karma to commit any related changes that you consider ready
for inclusion in trunk.
Is the text-rotation-081117.zip file in PDFBOX-374 ready to be
committed?
Yes. It fixes all of the examples that have been posted and fixes
some previously unknown issues in the regression tests.
PS. Instead of zipping the changed files, it would be nicer if you
used the patch format for proposed changes. Using "svn diff" from your
checkout of the PDFBox trunk will produce a nice patch that is easy
for me or any of the committers to review and apply.
OK. My previous patches were actual patches, but the ones I was
testing on the rotation issue were full file submissions, so I wasn't
sure if that was the local convention. I'll submit diffs in the
morning.
Three files in the regression test need to be updated. Should I also
upload those?
thanks,
brian
