Hi,
[x] -1 Do not release this package because...
The -src package contains stuff (target, external, tools) not included
in the svn tag. It looks like you packaged the source jar only after
building the binaries. Most notably the -src package includes the
Checkstyle jar that's LGPL code and that we therefore can't include in
a release package.
Other than that everything looks pretty good. The LICENSE and NOTICE
files included in META-INF of the pre-compiled jar cover also external
dependencies, which is not necessary in that context. There's also
been some recent Apache legal discussion (see LEGAL-62) about NOTICE
file contents, and it seems that my earlier understanding resulted in
us including too many details in NOTICE. Neither of these issues is
too serious and certainly not a blocker for the release.
BR,
Jukka Zitting
