[ 
https://issues.apache.org/jira/browse/PDFBOX-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754173#action_12754173
 ] 

Jukka Zitting commented on PDFBOX-524:
--------------------------------------

Just wanted to give people a chance to review and comment on the proposed 
changes.

It often seems like everyone has a different opinion on how logging should be 
done, so I'd rather wait for (lazy) consensus before committing this. :-)

> Drop LoggingObject
> ------------------
>
>                 Key: PDFBOX-524
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-524
>             Project: PDFBox
>          Issue Type: Improvement
>            Reporter: Jukka Zitting
>            Priority: Minor
>         Attachments: PDFBOX-524.patch
>
>
> The current LoggingObject base class breaks the "composition over 
> inheritance" principle. A more standard logging pattern is to use a separate 
> logger instance:
>     private static final Log log = LogFactory.getLog(ThisClass.class);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to