OK, since the tests are passing under the CI, I'll go ahead and merge it in.
Cheers,
- Zaki Mughal
On 2016-07-16 at 21:28:58 -0600, Derek Lamb wrote:
>
> > On Jul 16, 2016, at 9:07 PM, Zakariyya Mughal <zaki.mug...@gmail.com> wrote:
> >
> > On 2016-07-16 at 17:07:53 -0600, Derek Lamb wrote:
> >> Though I am not too familiar with the constructor code, the fact that it
> >> passes all tests with all combinations of BADVAL_USENAN and/or
> >> BADVAL_PERPDL is very encouraging.
> >>
> >> finite has been deprecated for quite some time: do you want to use
> >> isfinite instead? (otherwise I'm going to have to change it when I do
> >> another round of compiler warning cleanup!)
> >
> > Hi Derek,
> >
> > I'm not sure if it is deprecated. It appears to be used as a PDL
> > compatibility macro around various platforms' floating point
> > implementations. See `Basic/Core/pdlcore.c.PL` and usage through the
> > codebase with:
> >
> > git grep '\(is\)\?finite[[:space:]]*('
> > .
> >
> >
> > I agree that `isfinite()` is the modern C99 approach, but I am not sure
> > if switching to that is the best approach. If it is internal, it really
> > should
> > also be prefixed with something like `pdl_` or `_pdl_` purely for
> > namespacing reasons.
> >
>
> oh, no, it's not internal—it's the (is)finite that's in math.h or wherever.
> For expediency the "finite" was left but on some machines it is macro #def'd
> to isfinite. Probably pdlcore.c.PL's implementation is the most rigorous. I
> forgot that was in the same file you were working in here. Carry on.
>
> Derek
------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
pdl-devel mailing list
pdl-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pdl-devel
