Current frankenstein (c89b5b6 Fix win32 build issues) builds fine on a box
where I had troubles with OpenGL-0.6704_02
Thanks.
--
kmx
On 24.5.2016 16:17, Chris Marshall wrote:
I am able to apply the patches. Will update frankenstein shortly.
On Tue, May 24, 2016 at 8:20 AM, Chris Marshall <[email protected]
<mailto:[email protected]>> wrote:
Hi Rob-
I concur with your analysis. I've hand merged the
master and bfree into a new topic branch frankenstein.
Would you mind applying your various fixes and patches
to that? I'm out of POGL time for now.
kmx,christian,rob: If you let me know that tests pass
for the topic branch I will have time to make another
CPAN developers release to test in the wild. :-)
Thanks,
Chris
On 5/24/2016 06:25, [email protected]
<mailto:[email protected]> wrote:
Chris,
Something else I've just noticed is that in the OpenGL
Makefile.PL we have:
# Detect MINGW
our $IS_MINGW = 0;
if ($^O eq 'MSWin32' && !$IS_CYGWIN)
{
$IS_MINGW = (($Config{make} =~ /\bdmake/i) && ($Config{cc} =~
/\bgcc/i));
print "Build platform \$IS_MINGW==$IS_MINGW\n" if $IS_MINGW and
$verbose;
}
As of perl-5.24.0 it is possible to build perl on MSWin32 with
MinGW such that $Config{make} is gmake. (This is precisely what I
have done, though I think Strawberry Perl has stayed with dmake.)
It was a rather strange check to begin with.
For one thing, the condition that $^O eq 'MSWin32' implies that
the condition !$IS_CYGWIN will be met (afaict) - so specifying
both was overkill.
I think this should suffice:
# Detect MINGW
our $IS_MINGW = 0;
if ($^O eq 'MSWin32')
{
$IS_MINGW = (($Config{make} !~ /\bnmake/i) && ($Config{cc} =~
/\bgcc/i));
print "Build platform \$IS_MINGW==$IS_MINGW\n" if $IS_MINGW and
$verbose;
}
In fact, I don't think we even need to concern ourselves with the
value of $Config{make}. Just knowing that the OS is 'MSWin32' &&
that $Config{cc} is 'gcc' should be enough to imply 'mingw'.
So, unless I've overlooked something, we could correctly detect
mingw with simply:
# Detect MINGW
our $IS_MINGW = 0;
if ($^O eq 'MSWin32' && $Config{cc} =~ /\bgcc/i)
{
$IS_MINGW = 1;
print "Build platform \$IS_MINGW==1" if $verbose;
}
With this change in place (and with the patch I sent in my
previous post) opengl-0.6704_02 builds and tests fine for me with
perl-5.24.0.
Cheers,
Rob
------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
pdl-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pdl-general
