Hi Rob,
My patch command doesn't understand the diff you sent.
> patch < /g/chm/pdl/patches/Core-diff-sisyphus-20170428.txt
> patching file Core.xs
> patch: **** malformed patch at line 8:
PDL::Core::Dev::generate_core_flags()"
The best way to send patch compatible (and git friendly) patch files is to
get the latest git and then make your edits, do git commit for those
changes with a commit message. Then use the git format-patch <commit> to
produce a patch file.
HTH,
Chris
On Fri, Apr 28, 2017 at 9:23 AM, Chris Marshall <[email protected]>
wrote:
> If I recall correctly, I think that the cpan clients have a workaround for
> the @INC setting before perl 5.26 to keep things from breaking. Maybe that
> was why you didn't have a problem.
>
> On Fri, Apr 28, 2017 at 9:10 AM, <[email protected]> wrote:
>
>> -----Original Message----- From: Chris Marshall
>> Sent: Friday, April 28, 2017 9:59 PM
>> To: [email protected] ; perldl
>> Subject: Re: [Pdl-general] PDL "bitrot-fix" update
>>
>> Hi Rob-
>>>
>>> The fix for @INC is already in the current git.
>>>
>>
>> Oh, yeah ... it probably makes better sense to test the git version than
>> the stable release.
>>
>> So, of course, this time I'm testing by running 'perl Makefile.PL',
>> 'make', etc.
>> And I find that there are additional changes needed to some of the files
>> in Basic/Core - see attached Core-diff.txt.
>>
>> But most (if not all) of that code that the patch changes was present in
>> PDL-2.017 .... so why didn't it blow up when I built 2.017 with the exact
>> same build of perl 5.25.12 (by running 'cpan -i PDL') an hour ago ??
>>
>> Is CPAN.pm doing something to subvert these new oh-so-crucial security
>> measures ??
>>
>> Now I don't know what's going on.
>> (When I ran 'git pull' it updated to commit
>> d8df2ed24b74ffd6a5cfdd9c605266a4415950f9.
>> I suppose that's current.)
>>
>> Cheers,
>> Rob
>>
>>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
pdl-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/pdl-general
