Hello Zsolt, On Oct 1, 2011, at 22:03 , Zsolt Dollenstein wrote:
> I have recently started using powerdns (props for a great piece of > software!), however I bumped into what looks like issue #301 on your > bugtracker (http://wiki.powerdns.com/trac/ticket/301). It has two > patches attached to it but it looks like they have never been merged > in. Are there any problems with them? If so, I'm willing to rewrite & > test them so they can be included in future versions. I have looked at both options in the ticket: 1. add a change_date to the query and do a minor patch 2. add a max(..) query to getSOA The first option would break existing setups if they have custom queries. This is of course a matter of documentation but I try to be careful in changing behaviour. The second option will not break existing setups (but if someone has a custom database schema, he still won't get auto serial with it - which is fine). However, the verbatim copying of code from dnsbackend to gsqlbackend looks a bit verbose. If you could look into making sure the second patch is not a dumb verbatim copy of code from dnsbackend, I'd be happy to consider it. My apologies for taking so long to reply. Kind regards, Peter van Dijk _______________________________________________ Pdns-dev mailing list [email protected] http://mailman.powerdns.com/mailman/listinfo/pdns-dev
