If AnonymousClassDeclaration will be more like LambdaFunctionDeclaration than ClassDeclaration then you are right and we can use className to store AnonymousClassDeclaration. But I think annonymousClassDeclaration like in JDT would be cleaner. I will prepare version with extended ClassInstanceCreation and new AnonymousClassDeclaration expression for further discussion:)
On Mon, Jul 27, 2015 at 1:39 PM, Dawid Pakuła <[email protected]> wrote: > You were faster :P > > I think about second option, similar to LambdaFunctionDeclaration. > But, AnonymousClassInstance is really required? className is an Expression > in both ast's so could be AnonymousClassDeclaration also. > > JDT have annonymousClassDeclaration property for ClassInstanceCreation.. > > -- > Dawid Pakuła > +48 795 996 064 > > On 27 Jul 2015 at 13:24:53, Michał Niewrzał ([email protected]) wrote: > > Ok, I think I resolved my problem. Reorganized anonymous_class rule + > fixed conflicts and works ok for now :) > > Now I have different question. I'm not sure what approach would be better: > * extend ClassInstanceCreation and ClassDeclaration (similar to previous > php7 patches) > * create something like AnonymousClassDeclaration/AnonymousClassInstance > that will hold all info about anonymous class declaration > * third option? > > Michal > > On Sun, Jul 26, 2015 at 11:52 PM, Michał Niewrzał <[email protected]> > wrote: > >> Dawid, thanks for hint about conflicts. I noticed them but I didn't >> noticed that I have more than for PHP5.6:) Unfortunately after I removed 3 >> new conflicts situation is the same. I will keep looking :) >> >> On Sun, Jul 26, 2015 at 11:05 PM, Dawid Pakuła <[email protected]> wrote: >> >>> Java cup (and also java cup eclipse editor), reports 3 additional >>> Shift-Reduce conflict in compare to php < 7 parsers. >>> >>> Java Cup editor is available under >>> http://www2.in.tum.de/projects/cup/eclipse >>> Note Java 1.8 is required ;) >>> >>> -- >>> Dawid Pakuła >>> +48 795 996 064 >>> >>> On 26 Jul 2015 at 22:59:00, Michał Niewrzał ([email protected]) wrote: >>> >>> Hi, >>> >>> I'm working with with support for anonymous classes but I stuck with >>> defining rules for compiler parser. I used rules from php7 parser and for >>> DOM parser everything looks to work ok, but for compiler parser works ok >>> for definition like this: >>> >>> new class($tset) extends Date implements AAA{ >>> } >>> >>> but when I'm adding content to class definition then something is not >>> matched. I tried to found out what is wrong but without success. Maybe >>> someone will have idea how to handle this. I prepared very basic patch to >>> show where I started: >>> https://git.eclipse.org/r/#/c/52581/ >>> >>> Any help or suggestions would be most welcome:) >>> >>> Thanks, >>> Michal >>> _______________________________________________ >>> pdt-dev mailing list >>> [email protected] >>> To change your delivery options, retrieve your password, or unsubscribe >>> from this list, visit >>> https://dev.eclipse.org/mailman/listinfo/pdt-dev >>> >>> >>> _______________________________________________ >>> pdt-dev mailing list >>> [email protected] >>> To change your delivery options, retrieve your password, or unsubscribe >>> from this list, visit >>> https://dev.eclipse.org/mailman/listinfo/pdt-dev >>> >> >> > _______________________________________________ > pdt-dev mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://dev.eclipse.org/mailman/listinfo/pdt-dev > > > _______________________________________________ > pdt-dev mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://dev.eclipse.org/mailman/listinfo/pdt-dev >
_______________________________________________ pdt-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/pdt-dev
