Hi, I'm closer to option with clean parser and additional check for cases like invalid elements in constant declaration. Maybe we can create temporary build participant to handle this case and later we will move it to target semantic analysis mechanism?
Michal On Sat, Aug 15, 2015 at 9:46 PM, Dawid Pakuła <[email protected]> wrote: > Hi, > > I’m close to finish uniform variable syntax but I realised that after > migration to PHP7, problem with static access/assign will be no longer > reported. > > For example this: > class Test { > private $x = call(); > } > > from parser point is 100% valid since PHP7. PHP7 will throw special fatal > error later, while AST creation: > Constant expression contains invalid operations > > So, we lost a lot of valuable errors. > > I can restore it on parser or AST level. Or just ignore it for now: > 1. AST looks good on first look, but if behaviour will change we will have > a problem because compiler AST know nothing about PHP version. > 2. Our parser will be more complex than should be, but we can later move > these checks to semantic analysis. > > What you think? > -- > Dawid Pakuła > +48 795 996 064 > > On 4 Aug 2015 at 13:05:14, Michał Niewrzał ([email protected]) wrote: > > Hi All, > > I'm looking volunteer to work with Uniform Variable Syntax[1] :-) I'm a > little bit tired messing with parsers and help would be great. Of course I > can help with everything around this feature ;) > > [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=466967 > > Michal > > On Wed, Jul 1, 2015 at 12:29 AM, Dawid Pakuła <[email protected]> wrote: > >> Hi, >> >> nice to hear this! >> >> Because you want reuse php5.6 parser, I've finished patch for bug 467524 >> [1] and marked him as php7 blocker. >> >> [1] - https://bugs.eclipse.org/bugs/show_bug.cgi?id=467524 >> >> -- >> Dawid Pakuła >> +48 795 996 064 >> >> On 30 Jun 2015 at 21:22:36, Michał Niewrzał ([email protected]) wrote: >> >> Hi, >> >> I plan to start working with PHP7 support:) At the beginning I want to >> add something easy - Spaceship Operator ( >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=466964). With this patch I >> will add PHP7 interpreter (just copy of 5.6.) as a base for next RFC's. Any >> other ideas? >> >> Michal >> >> On Mon, May 11, 2015 at 11:15 AM, Michał Niewrzał <[email protected]> >> wrote: >> >>> Hi, >>> I created list of new features for PHP 7 support. It should be easier to >>> implement/review each functionality at once. If I missed something please >>> add it to the list. Everything can be found under PHP 7 support bug. >>> >>> https://bugs.eclipse.org/bugs/show_bug.cgi?id=465701 >>> >>> Michal >>> >> >> _______________________________________________ >> pdt-dev mailing list >> [email protected] >> To change your delivery options, retrieve your password, or unsubscribe >> from this list, visit >> https://dev.eclipse.org/mailman/listinfo/pdt-dev >> >> >> _______________________________________________ >> pdt-dev mailing list >> [email protected] >> To change your delivery options, retrieve your password, or unsubscribe >> from this list, visit >> https://dev.eclipse.org/mailman/listinfo/pdt-dev >> > > _______________________________________________ > pdt-dev mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://dev.eclipse.org/mailman/listinfo/pdt-dev > > > _______________________________________________ > pdt-dev mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://dev.eclipse.org/mailman/listinfo/pdt-dev >
_______________________________________________ pdt-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/pdt-dev
