On Sat, 2005-09-17 at 10:05 -0700, Ben Bleything wrote: > On Sat, Sep 17, 2005, Robby Russell wrote: > > I object! (sorta) > > > > I think it might be a better move if we use his class in the email > > script and call two separate scripts (one for the bot and one for the > > email). > > > > I am using the pdxrbot code already for an internal project (we have a > > bot/irc chan/etc). But, I don't have a mailing list to send commits to. > > So, it seems like using some shared code would be good, but the two > > purposes don't really relate outside of PDX.rb. > > I'm not sure I agree. Well... I guess I can see it both ways. That's > why I want to make sure you can turn off email if you don't want to use > it. > > Personally, for anything that I'd want IRC notification for, I'd also > want it by email. I think this is a fairly common case, but *shrug*. > > > So, to clarify... I think a shared class would be a good idea. Then, we > > can just work off of that base class for svn monitoring? > > To clarify my point: I guess I don't care that much, but I don't see any > reason to keep them separate either. A shared class would be fine with > me too, but then we run into problems having them in two separate > repositories... > > Ben
Okay. I concede. If we can keep it modular, that would be great. As we have been working on this, I have had this underlying feeling that we're going to want to actually rethink how we've done everything. Wouldn't it be pretty could if we had our a more centralized DRb instance that could juggle several options and we could interact with it from svn, rbot, the mailing list, the web site, etc? We could call it DRboctopus. :-) In the meantime, since you are the post-commit guru on this mini-project, I'll leave it to you to decide. Just keep a flag to decide whether or not we will have it send an email or not. I also think that John was going to redo the email sending with rmail... so you might check with him. Cheers, Robby -- /****************************************************** * Robby Russell, Owner.Developer.Geek * PLANET ARGON, Open Source Solutions & Web Hosting * Portland, Oregon | p: 503.351.4730 | f: 815.642.4068 * www.planetargon.com | www.robbyonrails.com *******************************************************/ _______________________________________________ PdxRuby-dev mailing list [EMAIL PROTECTED] http://lists.pdxruby.org/mailman/listinfo/pdxruby-dev
