On 10/28/2012 02:41 AM, Gopal Vijayaraghavan wrote:
> If I'm not wrong, this only breaks APC when include_once_override is turned
> on.
>
> My vote is to drop the apc.include_once_override and make APC a bit
> simpler & neater.
>
> I've found that it behaves rather inconsistently when people start
> returning values from scripts.
>
> <?php
> function f($a = array(1)) { return $a; }
> return f();
>
> has been a suspect case for some segvs.
Sorry, I didn't understand. Do you mean my change to include_once
override is causing new segvs or are you saying in general our
include_once override implementation has historically had problems?
I'd love to hear your suggestion for a simpler non-override way to solve
this particular inconsistency. Clearly the way the included_files check
is done currently is not ideal and I don't really see how we can solve
this in APC without doing an override since the actual check is done in
PHP's include_once code.
-Rasmus
--
PECL development discussion Mailing List (http://pecl.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
