Op 04-01-13 11:08, Jille Timmermans schreef:
1) What's the license? The code carries no license, neither do you state
in this mail.
I will look into that.
I've added the PHP license.
3) Your php_vdump.h is relatively long. In general it is good practice
to keep it small as it will be included from main/builtin_functions.c if
the extension is built statically.
IIRC it was mostly auto-generated by ext_skel but I will trim it down
as far as possible.
I've removed the useless defines.
5) I don't think MINFO is a good place for credits (while this is pecl
which is less strict and even in core we have examples doing that...)
I will remove it.
Done.
Updated code is at https://github.com/hexon/php-vdump
--
PECL development discussion Mailing List (http://pecl.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php