Hi,
thanks for your answer. :)
I do know runkit but I felt a bit unsatisfied with its features and I
also found some edge cases where it didn't work well since it was not
maintained for many years. Therefore we decided to build our own
extension and now it's already done. ;)
Concerning the (UN)EXPECTED() macros: I don't know why, I just like
them. A small improvement is still an improvement and GCC should do them
well. :)
Am 13.02.2013 20:29, schrieb Johannes Schlüter:
Hi,
On Wed, 2013-02-13 at 20:19 +0100, Yussuf Khalil wrote:
my name is Yussuf Khalil. Me and a friend have created the extension
DeepTrace, which we would now like to publish to PECL. DeepTrace allows
removing constants, classes and functions, adding and removing methods
from classes, catching calls to exit(), removing included files (making
them includable again via include_once/require_once), altering the
values of static variables inside functions along with some other features.
This sounds a bit like runkit. Have you thought about contributing your
additional features there instead of having "competing" extensions?
I scrolled quickly over the code and see that you're using quite a lot
of UNEXPECTED() macros, the effect of those is quite limited and leads
to more complex code being generated ... I'd use it for hotspots only.
(Seen too many compiler bugs in my life ;-) )
I've scrolled too fast to call this a proper review, though :-)
johannes
--
PECL development discussion Mailing List (http://pecl.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
