On 29 April 2013 11:30, Dominic Black <thephe...@gmail.com> wrote: > > Current source code is at; https://github.com/DomBlack/php-scrypt >
Just some comments: - the spl_ce_BadFunctionCallException must not be declared static, but extern. - if you depend on extensions like SPL and hash, delcare it with ZEND_MODULE_DEP - if a function is not available on a platform, do not even define the function - you shall use php_error_docref() - bundling libraries is discouraged, but not always possible Everything else looks pretty fine. :) -- Regards, Mike
