> > > Overall: +1. > > A few minor comments, some more for other reviewers who coulddisagree > with me ;-) >
Thanks again for all the feedback! I believe I have implemented all of the suggestions besides making the code C89 compatible. There are two reasons I did not do this: 1. Currently libmaxminddb is not C89 compatible. 2. When I tried building my extension with the -std=c89/ansi flag, I found that most of the failure appeared to come the PHP core header files. The extension does currently build with the -std=gnu89 flag. Before filling out the account request form, it looks like I need a sponsoring user. Is there any process for this or does someone just sign off on it? Thanks! Greg
