Hi, On 9 Dec 2013, at 12:26, Lars Strojny <[email protected]> wrote: > > Very interesting extension and I would very much like to see it in PECL. > Without having the time right now for a more thorough code review I would > strongly advise to add tests for your extension.
I’m working on doing that now, as it happens. I have a few tests but they’re not quite release-quality yet. I’m attempting to make it possible to run tests against a TLS-secured broker without too much hassle - I believe I have found a reasonable way to make this work now, though. > I know this can be hard for message queueing extensions (maintaining amqp > gave me more than a glimpse into that) but the investment is definitely worth > it. I can believe it! :-) Thanks for your feedback, Michael -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
