Hello John, just a few remarks:
https://github.com/trianglman/ellipticCurveSignature/blob/master/src/php_ellipticCurveSignature.c#L62 the "l" argument of zend_parse_parameters() accepts longs, not ints. zend_error() and E_ERROR are used for engine things _only_. There is no reason to stop script execution if a secret key is wrong, a simple warning is more than enough. AFAIK OpenSSL supports EC signatures, so why have add a new implementation instead of using and existing one? On 09/22/2014 06:55 PM, John Judy wrote:
Hi all, I've been working on my first PHP extension ( https://github.com/trianglman/ellipticCurveSignature) and I finally have it working and tested. I would really appreciate if some more people could look at it and let me know what I might have missed or better ways for me to do it. I would also appreciate any pointers for what I should do next to make it easy for others to access. The goal of the extension is to bring elliptic curve signing and verifying into an extension (as doing it in native PHP is incredibly slow). ED25519 was the curve I've been working with, but I've made it generic in order to make it easy to support other curves as I can add them. Thank you, John Judy
-- Wbr, Antony Dovgal --- http://pinba.org - realtime profiling for PHP -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
