Hey: Andrei, what do you think? thanks
On Wed, Dec 3, 2014 at 5:10 PM, Wei Dai <[email protected]> wrote: > Hi Laruence! > >> Hey Wei: >> >> On Fri, Aug 29, 2014 at 4:25 PM, Pierre Joye <[email protected] >> (mailto:[email protected])> wrote: >> > hi! >> > >> > On Fri, Aug 29, 2014 at 9:24 AM, Wei Dai <[email protected] >> > (mailto:[email protected])> wrote: >> > > Hi, >> > > >> > > I have made php-memcached available for php7, most test cases work fine, >> > > those cases can pass now. >> > > >> > > Is there anything else I need to do? Is there anyone can help me review >> > > the code please? >> > > >> > > it was already commit on my github, see: >> > > https://github.com/zxcvdavid/php-memcached/tree/php7 >> > > >> > > Thank you all, >> > >> > Thanks! >> > >> > Could you send a PR pls? Or a patch? I will merge it asap :) >> > >> > Also have to figure out what is the best way to deal with all the >> > differences. >> > >> > Cheers, >> > -- >> > Pierre >> > >> > @pierrejoye | http://www.libgd.org >> > >> > -- >> > PECL development discussion Mailing List (http://pecl.php.net/) >> > To unsubscribe, visit: http://www.php.net/unsub.php >> > >> >> How is this going? >> >> > > The PR is still open, see : > https://github.com/php-memcached-dev/php-memcached/pull/148/commits . > > I have no idea who can help me to review and merge it. > >> >> thanks >> >> >> >> -- >> Xinchen Hui >> @Laruence >> http://www.laruence.com/ >> >> > > Thanks! > > Wei Dai -- Xinchen Hui @Laruence http://www.laruence.com/ -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
