Hi, Remi. Thank you for reviewing and checking it on various PHP version. I released 1.2.6, which includes the bug fixes you pointed out.
I think that I got a favorable reviews, so I'll request PECL account. If there remains issues or discussions, please reply. 2017-06-14 18:32 GMT+09:00 Remi Collet <[email protected]>: > Le 14/06/2017 à 11:18, Yoshio Hanawa a écrit : > > Thank you for reviewing! > > > > 2017-06-11 16:36 GMT+09:00 Remi Collet <[email protected]>: > > > >> > >>> The extension is currently compatible with PHP 5.3.1 - 7.1.x > >> > >> Not compatible with PHP 7.2, mostly because of function prototype > >> > > > > Oh, Thanks. I've never tried PHP 7.2.x before. I could reproduce this > > problem on PHP 7.2.0alpha1 and I have fixed on master. > > > > > >> PHP Warning: Declaration of TimecopDateTime::createFromFormat($format, > >> $time, $object = NULL) should be compatible with > >> DateTime::createFromFormat($format, $time, ?DateTimeZone $object = > NULL) > >> > >> 1 failing test with 7.1 > >> > >> $ cat tests/core_005.diff > >> 007+ string(26) "1969-12-31 14:00:07.071129" > >> 007- string(26) "1969-12-31 14:00:07.000000" > > > > > > I cannot reproduce this one on my MacBook, however I guessed the bug > > and also fixed on master. I suppose that the bug occured only on > > powerful machine. > > > > > Indeed, with current master, everything seems ok (build + tests) > with PHP 5.6, 7.0, 7.1, 7.2 > > > >
