Hi Shige, On Tue, 2018-05-01 at 07:42 -0700, Shige Takeda wrote: > Hi Anatol and Derick, Thanks for the replies. > > I didn't submit an account request from the given page yet as the > page says I would have to communicate in [email protected] > first. > > libsnowflakeclient is in the separate repo: > https://github.com/snowflakedb/libsnowflakeclient > Would it be ok to have a link to the github link or need a source > code package as well? > Usually, if you expect a dependency not to be on some systems, like say some library is not in the package system, an option could be to bundle the sources with the extension. Fe see http://svn.php.net/viewvc/pecl/t rader/trunk/ how it's done with Ta-Lib. Another option is of course to let users to first compile the dependency themselves. Bundling static libraries is not portable and thus is suboptimal. Libraries like libcurl are usually available as distro packages, so the corresponding dev packages just need to be installed.
> With regards to C89 compatibility change, I can make changes for PDO > but not for libsnowflakeclient, which is used by other drivers, so it > includes C++ interface as well as pthread dependency. > All the comments concern the PHP extension sources only. As they'll be linked from the PECL site and are available through the pecl command, it usually makes sense to clear out issues before extensions get accepted. Dependency libraries is not something a PECL contributer is supposed to fix, anyway :) You might have seen it, but just for the case - there are several resources available in this regard here http:/ /pecl.php.net/support.php#resources Regards Anatol > Windows and MacOSX supports are on my todo list. > > Thanks, > -- Shige > > > > On Tue, May 1, 2018 at 2:40 AM, Anatol Belski <[email protected]> wrote: > > Hi, > > > > On Mon, 2018-04-30 at 12:48 -0700, Shige Takeda wrote: > > > Hi Pecl-Dev, > > > > > > Could you give me update about PECL account status? > > > > > A couple of comments: > > > > - C89 compatibility should be held, unlike here and other places > > https://github.com/snowflakedb/pdo_snowflake/blob/master/snowflake_ > > driv > > er.c#L507 > > https://github.com/snowflakedb/pdo_snowflake/blob/master/snowflake_ > > stmt > > .c#L578 > > - C style comments should be used in C sources > > - libsnowflakeclient and some other binaries are bundled in the > > repo. > > It is usually not feasible to redistribute binaries in the PECL > > packages. Either the libraries available on the system (preferable) > > are > > used or sources can be bundled. So far I could check, all the > > dependencies can be made available externally. > > - config.w32 seems not implemented. > > - The readme tells ext/json is a dependency, but there's no check > > for > > its presence, neither PHP_ADD_EXTENSION_DEP is used in m4 > > > > These are actually minor issues, the only real one is about not > > bundling any binaries, I guess. > > > > Regards > > > > Anatol > > > > > I will need to push Snowflake PDO in a couple months. > > > > > > Thanks, > > > -- Shige > > > > > > On Thu, Mar 29, 2018 at 5:07 PM, Shige Takeda <shige.takeda@snowf > > lake > > > .net> > > > wrote: > > > > > > > Hello, > > > > > > > > My name is Shige Takeda, an engineer at Snowflake Computing, > > Inc. > > > > https://www.snowflake.net/ > > > > > > > > Currently I have been developing PDO driver for Snowflake DB > > and > > > > hosting > > > > the source code here: > > > > https://github.com/snowflakedb/pdo_snowflake > > > > > > > > Now I would like to publish the PDO driver at PECL repository > > for > > > > the > > > > customers to download. > > > > > > > > The license is Apache 2 at the moment as all other drivers have > > the > > > > same. > > > > > > > > Could you give me a PECL account? > > > > > > > > Regards, > > > > Shige Takeda > > > > > > > > > >
