Hi guys, I've got an old Bencode extension and recently I've been thinking that maybe I can make some effort to get it into PECL. The code can be found at https://github.com/Frederick888/php-bencode and after quickly going through the PECL guidelines, it seems that there are quite a few changes I need to make. But before I action, it would be nice to have your suggestions on my TO-DO list in case there's anything missing.
What I currently plan to do are: 1. Re-license under PHP License 3.01 2. Fix class/method naming 3. Reformat the code. I plan to use the attached clang-format configuration, does it tick all the boxes? 4. Inline documentation & PECL Docs Please let me know if I overlooked something. Thanks. -- Best Regards, Frederick Zhang Email: frederick...@tsundere.moe
Language: Cpp AccessModifierOffset: -4 AlignEscapedNewlinesLeft: true AlignTrailingComments: true AllowAllParametersOfDeclarationOnNextLine: true AllowShortBlocksOnASingleLine: false AllowShortFunctionsOnASingleLine: None AllowShortIfStatementsOnASingleLine: false AllowShortLoopsOnASingleLine: false AlwaysBreakBeforeMultilineStrings: true AlwaysBreakTemplateDeclarations: true BinPackParameters: true BreakBeforeBinaryOperators: false BreakBeforeBraces: Linux BreakBeforeTernaryOperators: true BreakConstructorInitializersBeforeComma: false ColumnLimit: 80 CommentPragmas: '' ConstructorInitializerAllOnOneLineOrOnePerLine: true ConstructorInitializerIndentWidth: 4 ContinuationIndentWidth: 4 DerivePointerAlignment: false DisableFormat: false ExperimentalAutoDetectBinPacking: false IndentCaseLabels: true IndentWidth: 4 IndentWrappedFunctionNames: false IndentFunctionDeclarationAfterType: false MaxEmptyLinesToKeep: 1 KeepEmptyLinesAtTheStartOfBlocks: false NamespaceIndentation: None PenaltyBreakBeforeFirstCallParameter: 1 PenaltyBreakComment: 300 PenaltyBreakString: 1000 PenaltyBreakFirstLessLess: 120 PenaltyExcessCharacter: 1 PenaltyReturnTypeOnItsOwnLine: 1000 PointerAlignment: Right SpaceBeforeAssignmentOperators: true SpaceBeforeParens: ControlStatements SpaceInEmptyParentheses: false SpacesBeforeTrailingComments: 1 SpacesInAngles: false SpacesInCStyleCastParentheses: false SpacesInContainerLiterals: true SpacesInParentheses: false Cpp11BracedListStyle: true Standard: Cpp11 TabWidth: 4 UseTab: Never
signature.asc
Description: OpenPGP digital signature