On Sun, 2020-03-01 at 04:30 +0100, George Peter Banyard wrote: > The sources of the extension are available on my personal GitLab at > https://gitlab.com/Girgias/csv-php-extension >
I had a *quick* look and didn't see anything obviously bad (but I haven't spent time on it to ensure there's no buffer overflow or such, maybe extending fuzzing sapi with a fuzzer might verify it) only thing I don't really like is the terminology of "file" which should be "string" or "buffer" or similar as it's not operating with the file system. For a thing called "file" I'd expect to pass a file name or file resource handle. In general: Is the only issue with the functions PHP provides (maybe besides naming there ...) that they don't allow multi char delimiters or is there more? - I'd rather improve than replace. Secondly I wonder how performance compares to a pure-php implementation. The string operations should be of similar speed, but I guess scanning might be slower. Userland is simpler to maintain and less risky for buffer overflows etc. johannes -- PECL development discussion Mailing List (http://pecl.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
