"Luis Bernardo" <[EMAIL PROTECTED]> writes:

Hi Luis

I've send this reply to the pel-devel list as well as to you so that
everybody sees the answer.  I would appreciate it if you would send
your reply there too, you don't have to subscribe, just keep it in CC.

> [EMAIL PROTECTED] pel]# cd examples/
> [EMAIL PROTECTED] examples]# php dump-image.php
> /home/lmpmbernardo/photos/200001/20000108101956.jpg
>
> Fatal error: Cannot redefine class constant
> PelTag::XP_COMMENT in /usr/local/lib/php/pel/PelTag.php on
> line 1086
> [EMAIL PROTECTED] examples]# cd ..
> [EMAIL PROTECTED] pel]# grep XP_COMMENT PelTag.php
>   const XP_COMMENT                                        =
> 0x9C9C;
>   const XP_COMMENT                                        =
> 0x9C9C;
>       case self::XP_COMMENT:
>       case self::XP_COMMENT:
>       case self::XP_COMMENT:
> [EMAIL PROTECTED] pel]# php -v
> PHP 5.1.0RC7-dev (cli) (built: Nov 22 2005 23:43:23)
> Copyright (c) 1997-2005 The PHP Group
> Zend Engine v2.1.0-dev, Copyright (c) 1998-2005 Zend
> Technologies
> [EMAIL PROTECTED] pel]#

You're right, something is very wrong here :-(  I myself just happened
to upgrade to PHP 5.1.1 the other day and I was shocked to see PEL
give such a bunch of errors when I tried to run the test suite.

I was also surprised to see that we had such doubly-defined constants
at all... but the change went in on August 17 last year:

  http://cvs.sf.net/viewcvs.py/pel/pel/PelTag.php?r1=1.18&r2=1.19

Why wasn't this discovered sooner? :-(  Anyway, I'll of course fix it.

-- 
Martin Geisler                                     GnuPG Key: 0x7E45DD38

PHP Exif Library      |  PHP Weather             |  PHP Shell
http://pel.sf.net/    |  http://phpweather.net/  |  http://mgeisler.net/
Read/write Exif data  |  Show current weather    |  A shell in a browser

Attachment: pgpnpDN17e4O2.pgp
Description: PGP signature

Reply via email to