Hi Ethan,

I haven't reviewed everything yet, but I have these
comments/questions so far.

usr/src/uts/i86pc/os/intr.c
  intr_thread_prolog():294
  How come intrtime gets set to "t->t_intr_start - tsc_read()"
  and not "tsc_read() - t->t_intr_start" like everywhere else?
  Is it intentional?

  cpu_intr_swtch_enter():717
  Why are you using atomic_add_64() here?  It seems that 
  we're updating local CPU's counters everywhere else
  without using atomic ops.

- Andrei
This message posted from opensolaris.org
_______________________________________________
perf-discuss mailing list
perf-discuss@opensolaris.org

Reply via email to