Hi Drew, I took a look at your webrev and in general I think this looks good.
I only have a couple of nits: - Does it make sense to coalese the gamma code and PRNG code into a single module? - I've never done anything with Lex/Yacc, so I didn't review that code - In the two .f files you added, would it make sense to instruct the user that $iosize is being randomly set, and they shouldn't adjust the value? What happens in those two cases if the user sets $iosize? Nice work, -j On Tue, Jan 29, 2008 at 11:09:52AM -0800, Andrew Wilson wrote: > I have developed a new "random variables" feature for FileBench. A > general discussion of the approach is available at: > > http://www.solarisinternals.com/wiki/images/1/1d/FileBench_Random_Variables.pdf > > See the section headed "Current Proposal and Prototype" on page 7 of the > document for a description of the feature, and references to some of the > key design concepts described in other sections. > > The webrev is located at: > > http://cr.opensolaris.org/~dreww/filebench_random_variables/ > > Thanks, > Drew > _______________________________________________ > perf-discuss mailing list > perf-discuss@opensolaris.org _______________________________________________ perf-discuss mailing list perf-discuss@opensolaris.org
