On Sat, Apr 19, 2008 at 7:17 AM, eric kustarz <[EMAIL PROTECTED]> wrote:
> hey Denis,
>
> Thank you so much for the patch. Really. automake is not my speciality.
>
> Couple of small questions for you before i integrate your changes...
>
> 1) instead of adding:
> "
> +#ifndef HAVE_BOOLEAN_T
> +typedef enum { B_FALSE, B_TRUE } boolean_t;
> +#endif
> +
> +#ifndef HAVE_U_LONGLONG_T
> +typedef unsigned long long u_longlong_t;
> +#endif
> "
>
> to filebench.h, can you add <sys/types.h>?
No. I have tried that, but it didn't work, just because a standard
linux system don't have these types:
$ egrep -RsInw '(u_int64_t|u_longlong_t|boolean_t)' /usr/include/sys/types.h
So we must use a ifndef/endif to check if these types exist,
or otherwise change all these types in c files.
>
> 2) i image including <errno.h> instead of <sys/errno.h> works?
This did work, indeed; I have tested and it works well, too. I also
think <error.h> is better than <sys/error.h>.
>
> thanks!
> eric
>
And to [EMAIL PROTECTED] admins:
If you are willing, you could give the commit access to the filebench
sourceforge CVS repository, I'm willing to maintain the linux port, my
sourceforge username is rank1cheng.
BTW: there is still some inconsistence through all these documentation:
http://www.solarisinternals.com/wiki/index.php/FileBench
http://www.opensolaris.org/os/community/performance/filebench/
and some docs in the source tree;
1. what is the binary f scripts interpreter's name: go_filebench or filebench?
2. and the perf(or conf) files driven perl script: filebench or
runbench or benchpoint? There are several different named filebench
perl scripts, which is the correct one? Could you please the
maintainer remove others?
3. Please give some more description about every part of the source
tree, which provided on the sourceforge?
--
Denis Cheng
Linux Application Developer
"One of my most productive days was throwing away 1000 lines of code."
- Ken Thompson.
_______________________________________________
perf-discuss mailing list
perf-discuss@opensolaris.org
