Robert, I have looked at this patch. Is that your goal to add an install_examples target to install the binaries for the examples into /usr/share/doc/libpfm/.
A few questions: - why install the binaries as opposed to the source code? - why not include this as part of the install target? - why not provide a top-level install_examples target? Thanks. On Tue, Mar 25, 2008 at 6:53 PM, Robert Richter <[EMAIL PROTECTED]> wrote: > Signed-off-by: Robert Richter <[EMAIL PROTECTED]> > --- > config.mk | 1 + > examples/Makefile | 8 +++++++- > examples/x86/Makefile | 7 ++++++- > 3 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/config.mk b/config.mk > index a2e8d74..4e29ffc 100644 > --- a/config.mk > +++ b/config.mk > @@ -77,6 +77,7 @@ PREFIX=$(install_prefix) > LIBDIR=$(PREFIX)/lib > INCDIR=$(PREFIX)/include > MANDIR=$(PREFIX)/share/man > +EXAMPLESDIR=$(PREFIX)/share/doc/libpfm/examples > > # > # Configuration Paramaters for libpfm library > diff --git a/examples/Makefile b/examples/Makefile > index 704b23f..adbf836 100644 > --- a/examples/Makefile > +++ b/examples/Makefile > @@ -80,7 +80,13 @@ smpl_standalone.o self_standalone.o notify_standalone.o : > standalone.h > > distclean: clean > > +install_examples: $(TARGETS) > + @echo installing: $(TARGETS) > + -mkdir -p $(DESTDIR)$(EXAMPLESDIR) > + $(INSTALL) -m 755 $(TARGETS) $(DESTDIR)$(EXAMPLESDIR) > + @set -e ; for d in $(DIRS) ; do $(MAKE) -C $$d $@ ; done > + > # > # examples are installed as part of the RPM install, typically in > /usr/share/doc/libpfm-X.Y/ > # > -.PHONY: install depend > +.PHONY: install install_examples depend > diff --git a/examples/x86/Makefile b/examples/x86/Makefile > index dfcf686..adc6900 100644 > --- a/examples/x86/Makefile > +++ b/examples/x86/Makefile > @@ -39,7 +39,12 @@ clean: > > distclean: clean > > +install_examples: $(TARGETS) > + @echo installing: $(TARGETS) > + -mkdir -p $(DESTDIR)$(EXAMPLESDIR)/x86 > + $(INSTALL) -m 755 $(TARGETS) $(DESTDIR)$(EXAMPLESDIR)/x86 > + > # > # examples are installed as part of the RPM install, typically in > /usr/share/doc/libpfm-X.Y/ > # > -.PHONY: install depend > +.PHONY: install install_examples depend > -- > 1.5.3.7 > > -- > Advanced Micro Devices, Inc. > Operating System Research Center > email: [EMAIL PROTECTED] > > > ------------------------------------------------------------------------- This SF.net email is sponsored by the 2008 JavaOne(SM) Conference Register now and save $200. Hurry, offer ends at 11:59 p.m., Monday, April 7! Use priority code J8TLD2. http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone _______________________________________________ perfmon2-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/perfmon2-devel
