Patch applied.
Thanks for tracking this one down.

On Thu, Jul 17, 2008 at 10:38 PM, stephane eranian
<[EMAIL PROTECTED]> wrote:
> Corey,
>
> Will do as you suggested. I think it is already out in the minimal perfmon.
>
>
> On Thu, Jul 17, 2008 at 10:33 PM, Corey J Ashford <[EMAIL PROTECTED]> wrote:
>> Hi Stephane,
>>
>> On POWER, the interrupting PMDs start at 1.  This was how I noticed it was
>> off because a loop was looking to see if register 0 has an interrupt
>> pending.
>>
>> On Cell, the first interrupting PMD is register 0.
>>
>> You could get rid of it, but since the fix is pretty simple, maybe we should
>> live with it for now in the full perfmon2, but get rid of it for the minimal
>> kernel.
>>
>> - Corey
>>
>> Corey Ashford
>> Software Engineer
>> IBM Linux Technology Center, Linux Toolchain
>> Beaverton, OR
>> 503-578-3507
>> [EMAIL PROTECTED]
>>
>>
>> "stephane eranian" <[EMAIL PROTECTED]> wrote on 07/17/2008 12:56:16 PM:
>>
>>> Corey,
>>>
>>>
>>> There was indeed an initialization problem. Everybody got lucky. If
>>> the value is zero, then one some
>>> PMUs you may end up iterating some more in the interrupt handler.
>>> Given that for most PMU models,
>>> PMD registers start at index zero, I am thinking we should get rid of
>>> this field. It is only on Itanium that
>>> useful data registers start at 4.
>>>
>>> What about Power and Cell?
>>>
>>>
>>> On Thu, Jul 17, 2008 at 9:12 PM, Corey Ashford <[EMAIL PROTECTED]>
>>> wrote:
>>> > Hello,
>>> >
>>> > In debugging a multiplexing problem on perfmon2 for POWER, I discovered
>>> > that
>>> > first_intr_pmd in the pfm_regdesc structure is not initialized anywhere
>>> > (that I can find).  This patch adds the code to initialize
>>> > first_intr_pmd to
>>> > pfm_pmu_regdesc_init().
>>> >
>>> > - Corey
>>> >
>>> >
>>> > --
>>> > Corey Ashford
>>> > Software Engineer
>>> > IBM Linux Technology Center, Linux Toolchain
>>> > Beaverton, OR
>>> > 503-578-3507
>>> > [EMAIL PROTECTED]
>>> >
>>
>

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
perfmon2-devel mailing list
perfmon2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/perfmon2-devel

Reply via email to